Skip to content

Add tests for all PyPI METADATA versions (#4175)#4180

Merged
AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
alok1304:pypi-metadata-tests-4175
Apr 16, 2025
Merged

Add tests for all PyPI METADATA versions (#4175)#4180
AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
alok1304:pypi-metadata-tests-4175

Conversation

@alok1304
Copy link
Copy Markdown
Collaborator

@alok1304 alok1304 commented Mar 6, 2025 •
edited
Loading

Fixes #4175

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Alok Kumar alokkumarjipura9973@gmail.com

@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from c05f2be to be42f1d Compare March 6, 2025 17:15
@alok1304
Copy link
Copy Markdown
Collaborator Author

alok1304 commented Mar 6, 2025

@AyanSinhaMahapatra I am trying to add all PyPI METADATA versions, am I doing this correct & any more suggestions on this issue. What I improved in this issue.

@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from be42f1d to 90f320e Compare March 6, 2025 18:00
AyanSinhaMahapatra
AyanSinhaMahapatra requested changes Mar 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alok1304 Thanks++

See comments for some improvements, looking great otherwise.

Comment thread tests/packagedcode/data/pypi/metadata/v23/PKG-INFO-expected.json Outdated
Comment thread tests/packagedcode/data/pypi/unpacked_wheel/metadata-2.2/trimesh-4.6.1.dist-info/METADATA
@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from 9e70764 to 76bc57b Compare March 19, 2025 17:52
@pombredanne pombredanne mentioned this pull request Mar 28, 2025
Closed
@pombredanne
Copy link
Copy Markdown
Member

pombredanne commented Mar 28, 2025

@alok1304 can you also post the links of the wheels and sdist you have been using for tests?
This is useful for reference!

@alok1304
Copy link
Copy Markdown
Collaborator Author

alok1304 commented Mar 28, 2025

@pombredanne, Here are links to all wheels and sdist.

  1. Metadata-Version: 2.2
    Name: ForeTiS
    Version: 0.0.7
    wheel & sdist: https://github.com/grimmlab/ForeTiS/tree/master/dist

  2. Metadata-Version: 2.3
    Name: hatchling
    Version: 1.22.4
    wheel & sdist: https://pypi.org/project/hatchling/1.22.4/#files

  3. Metadata-Version: 2.2
    Name: trimesh
    Version: 4.6.1
    wheel & sdist: https://pypi.org/project/trimesh/4.6.1/#files

  4. Metadata-Version: 2.4
    Name: narwhals
    Version: 1.29.0
    wheel & sdist: https://pypi.org/project/narwhals/1.29.0/#files

AyanSinhaMahapatra
AyanSinhaMahapatra requested changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alok1304 see my review comments, please make you test files smaller by getting rid of large text portions which are not useful.

Comment thread tests/packagedcode/data/pypi/metadata/v23/PKG-INFO-expected.json Outdated
@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from bdbf1dc to 81183fb Compare April 7, 2025 12:36
@alok1304
Copy link
Copy Markdown
Collaborator Author

alok1304 commented Apr 7, 2025 •
edited
Loading

Hey @AyanSinhaMahapatra I reduce the description text.

@alok1304
add tests for PyPI METADATA versions
c97e9bc 
Ref: aboutcode-org#4175
Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from 81183fb to c97e9bc Compare April 11, 2025 18:11
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks++ @alok1304, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 3582983 into aboutcode-org:develop Apr 16, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure all versions of pypi METADATA parsing is tested

3 participants

@alok1304 @pombredanne @AyanSinhaMahapatra